New thread guidelines #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,4 +15,4 @@ | |||
| # addr = 127.0.0.1 | |||
|
|
|||
| # Port to listen on. | |||
| port = 80 | |||
| port = 8080 | |||
There was a problem hiding this comment.
If you want to change this then you should also update the README. Ideally it would be in its own PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69 by allowing to set a custom url for a thread that display the guidelines for this thread.
I thought supplying a URL is more flexible than hard-coding HTML and it's inspired after Github contribution guidelines:
https://github.com/blog/1184-contributing-guidelines
I think if it's an URL not all people won't bother reading anyway, so it's a less intrusive addition than putting some guidelines directly on the page. However also not as effective ;-)
Btw I had some troubles running DFeed, because for non-sudo user it isn't allowed to use ports lower than 1024. Hence as an improvement for other newcomers, the first commit sets the default port to 8080